support configuring proxy server in-app

Description

cloning a repo fails with "could not resolve host: github.com

Version

GitHub Desktop version: 1.0.8

OS version: Microsoft Windows [Version 10.0.10586]

Steps to Reproduce

1. clone any repo from github

Expected behavior: [What you expected to happen] Succeeding cloning repo

Actual behavior: [What actually happened] This fails with:

Cloning into ‘D:\GitHub\vsts-node-api’… fatal: unable to access ‘https://github.com/japj/vsts-node-api.git/’: Could not resolve host: github.com Error(s) during clone: git clone failed: exit status 128

Reproduces how often: [What percentage of the time does it reproduce?]

Logs

2017-11-10T08:58:45.992Z - info: [ui] [AppStore.getAccountForRemoteURL] account found for remote: https://github.com/japj/vsts-node-api.git - japj (has token) 2017-11-10T08:58:46.267Z - error: [ui] git -c credential.helper= lfs clone --recursive --skip-repo --progress -- https://github.com/japj/vsts-node-api.git D:\GitHub\vsts-node-api exited with an unexpected code: 2. Cloning into ‘D:\GitHub\vsts-node-api’… fatal: unable to access ‘https://github.com/japj/vsts-node-api.git/’: Could not resolve host: github.com Error(s) during clone: git clone failed: exit status 128

Additional Information

I am behind a corporate firewall, but there is no way to setup a proxy in the github desktop application?

[japj]

I think this might be an identical problem to #3264

Just asking to understand it better, is the intend that GitHub Desktop users will need to find out how to and do the setup of the proxy manually? I might have expected a more “integrated” proxy setting in the Options page.

[billygriffin]

Please follow along with this in #2789