unable to commit after cmd+enter
See original GitHub issueDescription
Partial crash. Unable to commit after hitting cmd+enter when having altered a single file.
Version
- GitHub Desktop: 1.5.0
- Operating system: macOS 10.14.1 (18B75)
Steps to Reproduce
- edit one file in repo.
- hit cmd+enter
Expected Behavior
File gets committed with commit message “Updated foo.bar”.
This is what happens when you manually click “Commit to master” instead of using the cmd+enter keyboard shortcut. This is also what happens when you focus the Summary field and then hit cmd+enter.
Actual Behavior
“Commit to master” button is disabled, file is not committed. Client has to be restarted to be able to commit.
Additional Information
none
Logs
Issue Analytics
- State:
- Created 5 years ago
- Comments:6 (4 by maintainers)
Top Results From Across the Web
Command+Enter to commit does not work anymore #89904
VSCode Version: Version: 1.42.0-insider Commit: be0aca7 Date: ... Run Preferences: Open Keyboard Shortcuts and search for Cmd Enter ...
Read more >git - I can't commit after push - Stack Overflow
I can't commit after pushing repo to github. What i'm basically trying to do is to clone some code from one github repository, ......
Read more >SOLVED: Xcode git commit keyboard shortcut – iOS
When working on my code, I like to commit to git often. I bring up the Commit popup window often via a keyboard...
Read more >Basic Git Tutorial - Embedded Systems Learning Academy
You will now be able to access Git in a new cmd window. ... After creating your commit you will want to 'push'...
Read more >unable to login ecc6.0 | SAP Community
hi guys,. i installed oracle 10g , ecc6.0 in my pc with 4gb ram, 300gb hdd... after installation,i try to enter the ecc6.0...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Hi @fschroiff, we discussed this quite a bit internally and unfortunately the technical work to achieve something that captures the commit keyboard shortcut outside of the commit area is nontrivial, and we’re not sure this would provide benefit for most users since we haven’t heard this before. I totally understand how this could make things more convenient for you, but it’s not something we intend to support unless we hear evidence that it’s causing more widespread pain and/or confusion (or frustration from lack of convenience).
I really appreciate you describing your expectation of how this would work, and hope you’ll continue to weigh in on things you’d like to see improved or that are causing frustration for you in the future. Thanks again! 😄
One note for future reference: the toggle of the checkboxes is just caused by hitting the
enter
key alone.@tierninho there might not have been a crash, I just interpreted the UI-state as being unresponsive. I had never even noticed the checkboxes ☑️ 👀. I learned now that focus on a file plus
cmd+enter
deselects the file (= un-checks the checkbox). And focus on the summary field pluscmd+enter
triggers a commit. This is the source of my confusion.So I’ll turn this from a bug-report into a feature request: When there’s an autogenerated summary (which is the case when only one file has been edited)
cmd+enter
should trigger a commit even when the files pane is focussed.