question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[UNTNG] Upgrade nudge from macOS to Desktop Electron

See original GitHub issue

This is part of #4285 and is for the work done on the macOS Desktop Classic application

Changes:

  • create a popup on app launch with read more and remind me later button
    • read more button opens the url: desktop.github.com/upgrade/classic/ AND reminds the user in 30 days
    • remind me later removes the popup and reminds the user in 30 days
    • clicking on the red traffic light x button removes the popup and reminds the user in 30 days
  • final image/copy (see last section in description)
  • update copy on About info that no longer says the app is up to date
  • provide some steps in the PR on how we can test the reminder popping up in 30 days in code review, given the fact that you are aware of the implementation details

User Flow functionalities to check: (let’s pretend the user is Tracy)

  • If Tracy opens the app and somehow quits the app without engaging in the popup (ex: killing the process), they will see the popup appears on the next app launch
  • If Tracy resizes the app or connects to an external monitor, the popup appears in the center with a fixed size (500px x 255px) no matter what
  • Tracy sees copy that matches macOS casing
  • Tracy sees a popup appears after 30 days if they 1) close the popup by x-ing out, 2) clicking on read more, or 3) clicking on remind me later
  • If Tracy clicks on read more, it’ll open desktop.github.com/upgrade/classic/ in whatever default browser they have

Other pieces:

  • Windows work - #4287
  • analytics

Notes:

  • img size is 500px x 255px
  • you are awesome and thank you

Design

Before

[Before] For popup: Before, Tracy sees Desktop Classic for macOS on app launch

[Before] For about: image 2

After

[After] For popup: upgrade dialog macos

[After] For about: about dialog macos

Image for popup modal

upgrade-nudge-image-mac

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

2reactions
joshabercommented, Mar 20, 2018

giphy-12

1reaction
agisilaoscommented, Mar 20, 2018

@joshaber Welcome back ❤️

Read more comments on GitHub >

github_iconTop Results From Across the Web

How To Create Your First Cross-Platform Desktop Application ...
Note: This tutorial was tested on macOS 10.15.3. Step 1 — Creating the Project. First you'll install Electron to your machine and create...
Read more >
Untitled
Iayyayo yen usurukkulle mp3, Vitan obat untuk apa, E-shop katastima xarilaou, Gall-peters projection ... Pygame camera mac, Apple macintosh performa 5200cd!
Read more >
Build Instructions (macOS) - Electron
Build Instructions (macOS). Follow the guidelines below for building Electron itself on macOS, for the purposes of creating custom Electron binaries.
Read more >
Untitled
Metal gear solid the essential collection pc, Whoishussain t shirt, Dessert tagalog ... Skyscraperpage sky city, Upgrade samsung shw-m250s ke jelly bean.
Read more >
Untitled
Camlytics review, Elftal barcelona 2011, Pch inquiry desk, Video de trenzas para el cabello, ... Dumping water from lake okeechobee, S max stereo...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found