update cleaning up old git.exe when it shouldn't

Description

@NickCraver reported on Twitter that he encountered this Git error, which is a generic and questionable message when we can’t resolve the packaged Git:

However after this he hasn’t been able to launch Desktop at all. No errors, no logs, just silence.

Version

GitHub Desktop version: 0.7.0 -> 0.7.2 OS version: Windows 10 I guess

Steps to Reproduce

TBC, seems to be something like this:

• Open app running 0.7.0
• Update app to 0.7.x (latest version) (in background? or manually?)
• Leave app open, keep doing Git things
• 💥

Expected behavior: The current version’s bits are still on disk until the app is closed, and cleaned up In The Future™

Actual behavior: Files related to the running app were cleaned up, and now the app doesn’t launch. Not sure if these are related, let’s assume so.

Reproduces how often: lol I have no idea

Logs

SquirrelSetup.log is interesting:

It excluded 0.7.1 and 0.7.2 when cleaning up old versions, but not the running 0.7.0 version. Could this be related to us rolling out delta updates? Full log is here

[shiftkey]

The downside is that we have a messed up updated that goes out, they now have to do the download + restart cycle twice.

I’m okay with this. Looking at the stats reported, the majority of people are still on 0.7.0.

But that’s worth it IMO to avoid breaking the app out from under users.

Yep, I’d rather an app that can be left running for days/weeks without trouble because Stuff Just Works™.

[NickCraver]

Open since at least last night, probably a few days at least…been working on Exceptional. It’s in a Parallels VM so it’d have paused during MacBook sleep over night, but up since this morning at ~6am EST.