Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

When staging lines and the `lint-staged` hook is used, the entire file is commited

See original GitHub issue

Description

Instead of commiting the staged lines, GitHub Desktop seems to commit the entire file

Version

GitHub Desktop version: 0.5.8 OS version: macOS 10.12.5 (Sierra)

Steps to Reproduce

Stage a few lines in a file
Write your commit message
Commit

Expected behaviour: Only the selected lines should be commited Actual behaviour: The entire file gets commited Reproduces how often: Always

Logs

2017-05-30T18:39:45.831Z - info: Stats reported.

Additional Information

Might not be useful here, but I should mention that the same thing seems to be happening in the new Atom Git Integration

Issue Analytics

State:
Created 6 years ago
Comments:26 (11 by maintainers)

Top GitHub Comments

1reaction

joshabercommented, Jun 2, 2017

Thinking about this more, I’m betting GitKraken and Sourcetree both use libgit2, in which case they build in hook support themselves. This means that their hook support won’t quite match git’s.

In this case, that happens to work the desired way. But it doesn’t match how git itself behaves, which I’d argue is the standard. So I think this is a won’t fix.

If we find that git itself also behaves how GitKraken and Sourcetree do, we can revisit this.

1reaction

joshabercommented, Jun 1, 2017

Interesting! I’ll change the title of this issue then.