[web3@1.0.0] Generated typings don't have BigNumber as a type

With web3@1.0.0 as target, generated types no longer support BigNumber for the contracts. As an example, this is the typing generated with web3@0.26.0 – https://github.com/MARKETProtocol/types/blob/develop/types/MarketCollateralPool.ts#L178 and the below is generated using web3@1.0.0 target which has string instead of BigNumber – https://github.com/MARKETProtocol/types/blob/feature/upgrade-web3-1.0.0/types/MarketCollateralPool.d.ts#L44

BigNumber might need some additional parsing while generating the types I guess. Would be really great if this can be supported soon. Thanks 😃

[hickscorp]

@sebastianst Thanks a lot. This is pretty much the same as we came up with as well. I think the TypeChain should allow for “configurable” BigNumber library. It is such a great tool, I think it would benefit from some little flexibility.

[krzkaczor]

@hickscorp don’t worry about it, you did a fine job on truffle-typings repo 😉

Some background on this feature. TypeChain under the hood uses https://github.com/krzkaczor/ts-generator which abstracts away some parts regarding type generation. What we could do is allow typechain users to provide custom “plugin” for ts-generator. All existing targets are just plugins for ts-generator.

CLI usage could look something like:

typechain --target=./typechain-generator.ts --outDir app/contracts './node_modules/neufund-contracts/build/contracts/*.json'