Typescript issue: weird dependency on node-fetch in declaration file

First of all thanks for awesome polyfill @developit. It’s brilliant and altogether with preact it makes a perfect match for our product bundle!

As for this issue I’m not sure why there’s a dependency on node-fetch in declaration file. When I try to use unfetch in my TS code I get this:

ERROR in [at-loader] ./node_modules/unfetch/src/index.d.ts:6:8 
        TS7016: Could not find a declaration file for module 'node-fetch'. '/Users/dsorin/.../node_modules/node-fetch/index.js' implicitly has an 'any' type.
      Try `npm install @types/node-fetch` if it exists or add a new declaration (.d.ts) file containing `declare module 'node-fetch';`

I know this can be fixed by installing typings for node-fetch but this leads to a further questions like “what’s this typing doing in our dependencies if we don’t use node-fetch package? let’s remove it”.

[1999]

Fair enough 👍

[mindplay-dk]

Is this why I’m getting a TypeScript error when I compile my project?

node_modules/unfetch/src/index.d.ts:7:8 - error TS2307: Cannot find module 'node-fetch' or its corresponding type declarations.

7 } from "node-fetch";
         ~~~~~~~~~~~~

If the typings in @types/node-fetch work, I don’t know why it’s a problem to just reuse those? But either way, it’s currently an undeclared dependency - you have to get a build failure and then manually install the package, so I think either that should be fixed, or the dependency should be removed?

(I don’t use the isomorphic stuff, so it’s all the same to me - but having a broken dependency definitely isn’t great.)