camera.onNewDing.subscribe doesn't work with motion anymore

I mostly followed ring/examples/example.ts

camera.onNewDing.subscribe(ding => {
        const event =
          ding.kind === 'motion'
            ? 'Motion detected'
            : ding.kind === 'ding'
            ? 'Doorbell pressed'
            : `Video started (${ding.kind})`

Only ding and other events were detected but not when there were motions.

It used to work but not now. I’m not sure if it’s related to recent changes in F2A/OAuth2 I have seen in HomeAssistant and python-ring-doorbell projects where I got them working with recent fixes.

However, for this node ring, somehow my motion detection capability’s gone while other functions seem to be working just fine.

Is anyone experiencing the same?

FYI: my ring git’s synced to HEAD, tag: v5.10.0 $ node -v v8.10.0

[sjiampojamarn]

I think I found the issue!! Ring has always had a concept of a session based on a hardware_id. What I never realized before was that each session can have its own settings. In this case, the session can subscribe and unsubscribe to motion and ding events. This is how each device that has the Ring app (phone, tablet, pc) can activate or deactivate the notifications for ding or motion events. Somehow your sessions settings must have gotten updated to unsubscribe from the motion events. I’ve added logic to automatically re-subscribe to those events for any camera that is unsubscribed when the code starts up. Please give v5.13.0 a try and see if you start receiving events again

Yes. Quick check. It works!!. Thank you for the great finding and awesome work.

[dgreif]

I think I found the issue!! Ring has always had a concept of a session based on a hardware_id. What I never realized before was that each session can have its own settings. In this case, the session can subscribe and unsubscribe to motion and ding events. This is how each device that has the Ring app (phone, tablet, pc) can activate or deactivate the notifications for ding or motion events. Somehow your sessions settings must have gotten updated to unsubscribe from the motion events. I’ve added logic to automatically re-subscribe to those events for any camera that is unsubscribed when the code starts up. Please give v5.13.0 a try and see if you start receiving events again 😄