Code Review

Great job so far! Here’s the things I stumbled upon:

Documentation

• Be consistent: timestep vs timestamp
• I don’t think we need to explain the layout of the option files; an example is sufficient.
• I think it is tremendously helpful to see example responses of the API calls early on.

Configuration

• Why split path and regex? Just have path_regex.
• Not sure about the yes/no syntax for boolean settings. How does e.g. Apache or Nginx handle that?

CLI

• Config path could be a positional argument
• Please wrap the config path in os.expanduser for us poor windows souls
• 💡: Accept rasters from the command line to quickly serve up anything: terracotta *.tif (then open a leaflet map in the browser, with the data already added as a layer, for the ultimate wow effect 😄)

API

• I don’t think the API queries should include terracotta. You would either run this as a Flask app on its own port, or configure the proxy in your webserver.
• Using a non-timestep API endpoint for a timestepped dataset causes an uncaught exception (500 server error; should give “Bad Request” or so)

---

I’ll have a look at the actual code and do some profiling later. I’ll update this issue with my findings.

[dionhaefner]

For future reference: the correct way to create COG

[mrpgraae]

It doesn’t, but in this case, mutating the metadata would keep the internal state intact. I actually meant something like

We will still have to be careful not to put any mutable types into the dict, but I guess that would be the same for frozendict.