Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Types are incomplete for Style

See original GitHub issue

Describe the bug The type declaration for Style is incomplete and unnecessarily duplicates information available from other sources of truth.

To Reproduce One example:

Attempt to use justifyContent: "flex-end" in a `Stylesheet.create({…})
Notice the TS error

You can make use of react-pdf REPL to share the snippet

Expected behavior Shouldn’t have a TS error

Screenshots N/A

Desktop (please complete the following information):

React-pdf version 1.6.4

Issue Analytics

State:
Created 4 years ago
Reactions:1
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

diegomuracommented, Sep 9, 2019

All merged! Thanks for your effort. I’ve been traveling these past few days and couldn’t dedicate that much time to the project but I’ll soon!

1reaction

diegomuracommented, Aug 26, 2019

Hey! Not sure about using csstype, since react-pdf does not support all the CSS spec. Adding these types will give a confusing idea that we do, creating a lot of frustration when some don’t work. Pinging @rzymek who did the original styles types. I would be happy to merge any PR that fixes missing types

Top Results From Across the Web

Incomplete types in template code - c++ - Stack Overflow

Suppose we have two types (complete and incomplete):

Incomplete Types - Microsoft Learn

An incomplete type can be: A structure type whose members you have not yet specified. A union type whose members you have not...

Incomplete Types - Oracle® Developer Studio 12.6

There are only three variations of incomplete types: void, arrays of unspecified length, and structures and unions with unspecified content. The type void ......

Incomplete type - PVS-Studio

Incomplete types include: the void type;; structs, classes, and unions, for which an implementation has not yet been defined;; unknown size ...

A very incomplete font style that communicates ... - Pinterest

A very incomplete font style that communicates mystery. Almost looks like another language. Free font, Fonts, Logo fonts.