Gradle: Fail Build if not formatted (with compileJava.dependsOn('spotlessApply'))

I am using Gradle 5.2 with version 3.24.2 of the spotless plugin.

I want to format JSF XHTML files using the eclipse formatter, using the following config:

...
if (!isCI) {
  project.afterEvaluate {
    compileJava.dependsOn('spotlessApply')
  }
}
...
spotless {
  format 'xml', {
    target '**/*.xhtml'
    eclipseWtp('html')
    indentWithSpaces(2)
    endWithNewline()
    trimTrailingWhitespace()
    paddedCell()
    encoding 'UTF-8'
  }
}

The goal is to automatically format the source on every build, when not in the CI environment but fail, if in the CI environment and the source is not formatted.

Formatting on every build works due to the afterEvaluate block, but when running ./gradlew check or ./gradlew spotlessCheck on unformatted sources, either in the CI environment or with the afterEvaluete block commented out, the build does not fail.

What am I missing? I want check and spotlessCheck to fail, if the sources are not formatted…

[nedtwigg]

Fixed in 3.24.3. Thanks for the testcase!

[nedtwigg]

Yep. Lots of formatters have non-idempotent corner-cases. Looks like your prod repo has one of them. That’s what paddedCell is for, but clearly something about it is broken. Your test repo is a perfect testcase for fixing it, and I’m happy to merge any PR’s, but I won’t get to investigating and implementing a fix myself until this weekend. I expect we should be able to ship a fix on Monday.