JavaScript Libs ContractId type conversion regression

A forum user pointed out a regression when upgrading the da-marketplace app from Connect 1.7 to 1.10.

It looks like there used to be a successful type inference from string to ContractId<AssetDeposit> in https://github.com/digital-asset/da-marketplace/blob/master/ui/src/components/Broker/BrokerOrders.tsx#L163. However, this now fails.

A workaround is to manually cast the string:

    const handleAcceptBrokerOrderFill = async () => {
        const key = wrapDamlTuple([props.cdata.broker, props.cdata.brokerOrderId])
        const cid = depositCid as ContractId<AssetDeposit>
        const args = { depositCid: cid }
        await ledger.exerciseByKey(BrokerOrder.BrokerOrder_Fill, key, args);
        setDepositCid('');
    }

[cocreature]

I’d got for ContractId<AssetDeposit> | undefined but yeah something along those lines.

[bame-da]

Thanks for the detective work. Makes perfect sense. I guess the correct solution would be to type the state properly:

    const [ brokerOrderId, setBrokerOrderId ] = useState<ContractId<AssetDeposit> | null>(null);