Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Transaction service accepts requests without parties and returns an empty stream

See original GitHub issue

The transaction service currently accepts a SubmitRequest with a filter with an empty set of parties and returns an empty stream. Probably a better approach would be requiring at least one party to be there to subscribe to and return an error if it’s not there, rather than opening (and possibly keeping it that way) an empty stream. This would ensure that the user gets an immediate feedback, rather than (possibly mistakenly) subscribing to a feed that will always be empty.

Another possible approach could be changing the semantics of an empty set of parties to mean “subscribe to all transactions over which I have visibility”, but I’m not sure this would be desirable.

Issue Analytics

State:
Created 4 years ago
Reactions:2
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

stefanobaghino-dacommented, May 20, 2019

I don’t see a BAD_REQUEST, maybe you were referring to this? Seems apt.

    /**
     * Client specified an invalid argument.  Note that this differs
     * from FAILED_PRECONDITION.  INVALID_ARGUMENT indicates arguments
     * that are problematic regardless of the state of the system
     * (e.g., a malformed file name).
     */
    INVALID_ARGUMENT(3),

0reactions

stefanobaghino-dacommented, May 20, 2019

BAD_REQUEST it is then, a PR is coming soon, thanks for the input. 🙏

Top Results From Across the Web

CreateStream - Amazon Kinesis Data Streams Service

CreateStream is an asynchronous operation. Upon receiving a CreateStream request, Kinesis Data Streams immediately returns and sets the stream status to ...

javascript - Return an empty Observable

In this case I can only do a request if hasMore() is true, else I get an error on subscribe() function subscribe is...

Writing REST Services with RESTEasy Reactive

This guide explains how to write REST Services with RESTEasy Reactive ... may accept as HTTP request body or produce as HTTP response...

Getting Started with Spring WebFlux

In a non-blocking system, all the incoming requests are accompanied by an event handler and a callback. The request thread delegates the ...

Change Log – Binance API Documentation - GitHub Pages

New WebSocket stream GRID_UPDATE in USER-DATA-STREAM: update when a sub order of a grid is filled ... stop being maintained and no longer...