Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Create single file for theme related content

See original GitHub issue

Is your feature request related to a problem? Please describe. I would like to extract all colors, padding, margin, text size etc into single theme.js. This will help customize the styling of the app really straight forward, and client can modify the theme to reflect their brand style.

Describe the solution you’d like

Create colors.js to hold all colors used in app
Create spacing.js that will hold standard spacing used for padding and margin.
Create typography.js to hold standard Text styles that can be reuse in entire app
Merge all color, spacing, typography into single theme.js which will be used by all component

Additional context I have implemented in my magecart repo, you can see it for reference.

Can I do it?

Issue Analytics

State:
Created 4 years ago
Comments:7 (3 by maintainers)

Top GitHub Comments

1reaction

dimaportenkocommented, Oct 7, 2019

hey @alexakasanjeev, Wow! Amazing work! I did smoke test the app on iOS and it looks really great! I haven’t reviewed all code yet but generally looks good.

There is no ‘sans-serif’ font on iOS by default, so I pushed the fix for it.

You can find some default fonts per OS here

Also, I see a lot of warnings appear, so need to review it as well.

1reaction

dimaportenkocommented, Oct 4, 2019

@alexakasanjeev not sure how those components appeared in the project, fill free to remove them if it is not used.