Move `@types` packages to `dependencies` from `devDependencies`

Bug report

• I have checked other issues to make sure this is not a duplicate.

Describe the bug

I have a following error after running tsc --noEmit:

error TS7016: Could not find a declaration file for module 'yup'

This should be fixed by moving all @types modules to dependencies, not devDependencies (I should not install type definitions for package that is not my dependency.

[maticzav]

Makes sense now. I will implement the fix by the end of the week.

If you have some spare time, I could merge a PR as soon as it lands.

[Paulooze]

Short answer is yes.

Files src/constructors.ts and src/rules.ts export stuff that uses yup types, therefore they (@types/yup) should be available to the consumer (installing them as production dependencies). Example:

export const inputRule = <T>(
  name: string | ((yup: typeof Yup) => Yup.Schema<T>),
  schema?: (yup: typeof Yup) => Yup.Schema<T>,
) => {
  if (typeof name === 'string') {
    return new InputRule(name, schema(Yup))
  } else {
    return new InputRule(Math.random().toString(), name(Yup))
  }
}

Now, let’s say I use inputRule inside my code. My typescript doesn’t know what Yup.schema<T> or typeof Yup means, because I don’t have @types/yup package installed (as I don’t directly use yup package). Hope this make sense. This is a longer answer, because you don’t use yup only during development, but also in the distributed package.