Possibility to re-use shield rule in resolver

Question about GraphQL Shield

Hi, first of all thanks for this great library and project! It saved me a lot of headache and time. 😄

Now for the question, how can I reuse a rule defined for graphql-shield in a resolver? This would make the checking of inputs for mutations less repetitive. Below an example of the ideal case for re-useability.

Resolver

import { isAdmin } from "../../../shield/rules";

const updateUser = async (parent, { data: { userId, ...data } }, context, info) => {
	/* ----------  Validation  ----------*/
	await updateUserSchema.validate(data);

	// You are not an admin, so you can't pass the role
	if (!(await isAdmin()) && data.role) {
		throw new Error("You are not allowed to update the role");
	}

	/* ----------  Process  ----------*/
	return User.update(userId, data);
};

export default updateUser;

graphql-shield rule

export const isAdmin = rule()(async (parent, args, { req }) => req.user.role === "ADMIN");

Mutation and input type

type Mutation {
	updateUser(data: UpdateUserInput): User!
}

input UpdateUserInput {
	userId: String!
	role: UserRoleEnum
	firstName: String
	lastName: String
	telephoneNumber: String
	email: String
	password: String
	language: LanguageEnum
	notificationLevel: NotificationLevelEnum
}

[maticzav]

This is not stale. Thank you for your patience and your example. I don’t think it’s worth making rules accessible in the bussiness layer of your application. Since rules can only fail or succeed, you should have sufficient information inside your resolver about the information you are testing (i.e. isAdmin in the example).

Differentiating between roles in resolvers seems like a bussiness logic that would be very hard to solve with graphql-shield. I want to keep shield serparted from business logic. I hope you understand. 🙂

[nealoke]

Actually it makes sense as you describe it, the app I use this (awesome) library for also is fine without it 👍