Rules with parameters

Is there a way to have a rule with some input arguments?

I am trying to make a rule like this:

const hasRole = (roleName: string) =>
    rule(`userHasRole-${roleName}`)(
        async (parent, args, ctx, info) => {
            return (ctx.user && ctx.user.role === roleName);
        }
    );

And then use it in this way:

Mutation: {
    createUser: and(user.hasRole("admin"), input.createUser),
},

And this gives me a run-time error:

Error: There seem to be multiple definitions of these rules: userHasRole-admin

I understand that this is exactly what is explained in the documentation. However my question remains, is there a way to have such rules with graphql-shield? I want to use rules for different claims that may be issued to a user. The total number of claims may be quite big and I don’t really want to define a separate function for every claim/role that may exist.

[maticzav]

Hey 👋 ,

That’s a fascinating question. Could you try creating role-specific rules before assigning them to the rule tree? Something like that:

const hasRole = (roleName: string) =>
    rule(`userHasRole-${roleName}`)(
        async (parent, args, ctx, info) => {
            return (ctx.user && ctx.user.role === roleName);
        }
    );

const hasAdminRole = hasRole("admin")
const hadUserRole = hasRole("user")

const permissions = shield({
  Query: {
    user: hasUserRole,
    admin: hasAdminRole,
  },
 Mutation: {
   createUser: hasAdminRole,
  }
})

What the error is saying is that you are trying to use two different rules with the same name (because you create multiple instances). Let me know if that worked; otherwise, we’ll try something new 😄

[maticzav]

@peterrogov happy to hear that. Thank you for a great thread!

I’ll close the issue as it seems to be resolved but feel free to reopen in case you feel there’s more to it.