Memory leaks in BlockingBlurController

Hello, @Dimezis

I’m using your librray in such way: Activity -> Fragment -> RecyclerView Item with blurred background. So, when I replace fragment with recyclerview and blured items to another one I’m getting several leaks detected by LeakCanary.

screenshot #1 screenshot #2 screenshot #3

In my (and LeakCanary’s) opinion the leak was caused by anonymous class in BlockingBlurController#deferBitmapCreation (read here about it)

I tried to remove it at all and as result no leaks detected and lower memory consumption achieved. So I can suggest to make that class static.

private static class SizeHandler implements ViewTreeObserver.OnGlobalLayoutListener {

        private WeakReference<View> blurView;
        private SizeHandlerListener listener;

        SizeHandler(View blurView, SizeHandlerListener listener) {
            this.blurView = new WeakReference<>(blurView);
            this.listener = listener;
        }

        @Override
        public void onGlobalLayout() {
            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {
                blurView.get().getViewTreeObserver().removeOnGlobalLayoutListener(this);
            } else {
                legacyRemoveOnGlobalLayoutListener();
            }

            int measuredWidth = blurView.get().getMeasuredWidth();
            int measuredHeight = blurView.get().getMeasuredHeight();

            listener.onSizeClarified(measuredWidth, measuredHeight);
        }

        @SuppressWarnings("deprecation")
        void legacyRemoveOnGlobalLayoutListener() {
            blurView.get().getViewTreeObserver().removeGlobalOnLayoutListener(this);
        }
    }

    private interface SizeHandlerListener {
        void onSizeClarified(int measuredWidth, int measuredHeight);
    }

And call it from function like it:

private void deferBitmapCreation() {
     new SizeHandler(blurView, this::init);
}

This solution fixed memory leak for me.

Regards, Alexey Egin.

[masc3d]

@DominuS-RU could you check if you still see leakage with patch com.github.masc3d:blurview:17c1cdc48c

it requires repositories { maven { url 'https://jitpack.io' } }

[Dimezis]

@masc3d would really appreciate it