Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Retina images don't preserve aspect ratios

See original GitHub issue

I have one portrait image, which looks stretched. What I did was adding this to config:

ratio: 1.5,
replaceSrc: function(item) {
   return item.src.replace(/\/\d+\//, function () {
      return '/1920/';
    });
}

my images come in different widths though, so I was not using the @2x modifier. When I open the image, it fills the screen height, but the width seems to be wrong.

Issue Analytics

State:
Created 9 years ago
Comments:5

Top GitHub Comments

2reactions

rainerroesingcommented, Dec 12, 2015

I solved it by removing the bold lines.

if(ratio > 1) {
                    _mfpOn('ImageHasSize' + '.' + RETINA_NS, function(e, item) {
                        item.img.css({
                         'max-height': item.img[0].naturalHeight / ratio,
                         'width': 'auto'
                        });
                    });
                    _mfpOn('ElementParse' + '.' + RETINA_NS, function(e, item) {
                        item.src = st.replaceSrc(item, ratio);
                    });
                }

0reactions

Hip-Priestcommented, Mar 18, 2015

I’m seeing this too. Had me very confused for a while! Any fixes for it yet?