vcs import hangs if environment variables are in the --input path

We use vcstool in our CI server to clone repos files with lines like,

vcs import --input $CI_PROJECT_DIR/repos_file.repos $MY_WORKSPACE/src

This has been working fine for us until yesterday. Now it hangs on any import lines where there are environment variables in the paths. I also see there might have been an update yesterday? This is all going on in a docker, but I can confirm that the docker is using vcs 0.1.26.

Edit: Can also confirm that on another computer trying the same thing with vcs 0.1.22 that it has no problem with environment variables in the args.

Edit+: Can also (unsurprisingly)show that it’s not actually the environment variables causing the problem. With valid manually entered paths I can make it hang. I know this doesn’t really help much, but the line i’m using is,

vcs import --input /builds/DD/repos_dir/repos_file.repos /builds/DD/deps_ws/src

Edit++: If I modify the path arg to be . then it works, so I guess it’s something with the way it’s handling the path arg

Edit+++: Sorry for all the edits, just trying to provide as much info as possible, but I think I have shown that if the path arg is any absolute path then it hangs. Tried to import to /tmp and it hung(was in a docker, so I was root).

[dirk-thomas]

Thank you for reporting the problem so quickly!

#44 fixed the regression.The latest version 0.1.27 contains the fix. Depending on where you fetch this package from it might take a bit to appear in the public repos / mirrors.

[kensley]

Thanks for the rapid fix Dirk. Is there a unit test we can add to test this?