Promotions approval percentage

Should the calculated approval percentage for campaigns be Approved / (Approved + Abstained + Opposed) or Approved / (Approved + Opposed)? I noticed that the !promotions command includes abstains in the total, but the progress bar on the web page doesn’t. Which is the preferred method?

[jmazouri]

Yes, the math should be Approved / (Approved + Opposed) - abstained are not taken into account at all. The frontend is using the correct logic - see the bars on https://mod.gg/promotions for an example.

For example, a campaign with 4 upvotes, 5 neutral votes, and 1 downvote should be at 80%.

[joshuaedwardcrowe]

Looking at picking this up. Current code seems to summarise as round((approved / total) * 100), are we agreed on rround((approved / ((approved + opposed) - abstained)) * 100)?

See below for evidence:

public static double GetApprovalPercentage(this PromotionCampaignSummary campaign)
{
    var totalApprovals = campaign.CommentCounts
        .Where(x => x.Key == PromotionSentiment.Approve)
        .Select(x => x.Value)
        .Sum();

    double totalVotes = GetTotalVotes(campaign);

    return totalApprovals / totalVotes;
}