500: Internal Server Error - breaks the whole thing

After receiving a server error 500 the whole bot stops to function correctly, it’s no longer receiving any messages, but it can still send them… This happened last night on several bots with completely different code, and even different version of Discord.NET (one with the latest commit on dev, the other with a bit outdated nuget…) So I guess that it’s safe to assume that it’s Discord server issue, however, the library should probably correctly handle it - adding another hack (if 500 then exit) doesn’t seem like the right solution, even as far as hacks go…

This stack started with client.GetGuild(guid)

May 25 03:20:10 Keyra dotnet[29615]: Exception: The server responded with error 500: 500: Internal Server Error
May 25 03:20:10 Keyra dotnet[29615]: Stack:    at Discord.Net.Queue.RequestBucket.<SendAsync>d__18.MoveNext()
May 25 03:20:10 Keyra dotnet[29615]: --- End of stack trace from previous location where exception was thrown ---
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
May 25 03:20:10 Keyra dotnet[29615]:    at Discord.Net.Queue.RequestQueue.<SendAsync>d__14.MoveNext()
May 25 03:20:10 Keyra dotnet[29615]: --- End of stack trace from previous location where exception was thrown ---
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
May 25 03:20:10 Keyra dotnet[29615]:    at Discord.API.DiscordRestApiClient.<SendInternalAsync>d__62.MoveNext()
May 25 03:20:10 Keyra dotnet[29615]: --- End of stack trace from previous location where exception was thrown ---
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
May 25 03:20:10 Keyra dotnet[29615]:    at Discord.API.DiscordRestApiClient.<SendAsync>d__57`1.MoveNext()
May 25 03:20:10 Keyra dotnet[29615]: --- End of stack trace from previous location where exception was thrown ---
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
May 25 03:20:10 Keyra dotnet[29615]:    at Discord.API.DiscordRestApiClient.<GetChannelMessageAsync>d__75.MoveNext()
May 25 03:20:10 Keyra dotnet[29615]: --- End of stack trace from previous location where exception was thrown ---
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
May 25 03:20:10 Keyra dotnet[29615]:    at Discord.Rest.ChannelHelper.<GetMessageAsync>d__6.MoveNext()
May 25 03:20:10 Keyra dotnet[29615]: --- End of stack trace from previous location where exception was thrown ---
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
May 25 03:20:10 Keyra dotnet[29615]:    at Discord.WebSocket.SocketTextChannel.<GetMessageAsync>d__19.MoveNext()
May 25 03:20:10 Keyra dotnet[29615]: --- End of stack trace from previous location where exception was thrown ---
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
May 25 03:20:10 Keyra dotnet[29615]:    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
May 25 03:20:10 Keyra dotnet[29615]:    at Botwinder.Service.SkywinderClient.<MainUpdate>d__8.MoveNext() in /home/project/Botwinder.service/Bot.cs:line 64

[FiniteReality]

Like… if something then if something then if something then if something then do something? No thanks 😄

I was suggesting something like this instead:

var mainGuild = this.Client.GetGuild(this.Config.MainGuildId);
var statusChannel = mainGuild?.GetTextChannel(this.Config.StatusChannelId);

if (mainGuild != null && statusChannel != null)
{
    var statusMessage = await.GetMessageAsync(this.Config.StatusMessageId);
    if (statusMessage != null)
    {
        // code here
    }
}

Don’t put assignments in if statements. It’ll only serve to confuse you later on.

[foxbot]

hey kids please don’t fight on my github issue, this has been answered, thanks.