Presence updates should trigger GuildMemberUpdated

Up to commit 3bd920ce66d6f7ff24bdf6e7077ea24499ddb9c5 I used UserPresenceUpdated to track when someone comes online or goes offline in order to update user counter on a web widget (which is per guild). Since the merge there is no way to retrieve information about guild where that event happened from event itself since it’s passing only 2 SocketUser parameters.

Even if I resort to extensive checking in which guilds user is joined there is this problem that we now treat UserUpdated as global event but it’s in fact not. Event is fired per guild, not per user, meaning if 1 user is in 3 guilds where bot resides his single status change will result in 3 identical event executions, that can’t be intended.

public DiscordWidgetService(IDependencyMap map)
{
    client.UserUpdated += Client_UserUpdated;
}

async Task Client_UserUpdated(SocketUser arg1, SocketUser arg2)
{
    await Console.Out.WriteLineAsync($"UserUpdated fired for {arg2.Username}");
}

[Auralytical]

Funny since I talked to Jake 3 weeks before that and was told to do it globally. Will ask around =\

Edit: Oh… the user is global and presence isn’t? Ugh. Have I mentioned how much I hate PRESENCE_UPDATE?

[khionu]

Our options are limited, because of the way the Discord API is structured. We’ve discussed this issue extensively, and this is the best we can do, for now.