Review Events

As Discord grows, we’re given two options: keep events centralized, where adding a reaction, attachment, embed or editing text would all be grouped under MessageUpdated, or we can add an event for every change (see JDA).

If we centralize them, maybe we should look into some sort of change list. Something like:

client.MessageUpdated += (msg, changes) =>
{
    if (changes.Content.Changed)
    {
        var before = changes.Content.Before;
        var after = changes.Content.After;
        //Do something
    }
    foreach (var reaction in changes.Reactions.Added)
    {
        //Do something
    }
};

Thoughts?

[Aux]

It’d make sense to split message-related events into their own events. While it could work fine to combine message edits and adding and removing reactions into a single event, it’ll be cumbersome in the future as more message-related events are added. The MessageUpdated handler will just end up a long condition check to ignore all of the unnecessary information being thrown at them because someone didn’t feel like adding another event.

client.MessageUpdated += (msg) =>
{
    if (msg.ActionA)
        await OnActionA();
    else if (msg.ActionB)
        await OnActionB();
    else if (msg.ActionC)
        await OnActionC();
    else if (msg.ActionD)
        await OnActionD();
};

etc…

Compared to

client.ReactionAdded += (msg, reaction) =>
{
    Do();
    Stuff();
    Here();
};

I am, however, for keeping all of the UserUpdated information stored in it’s own event as long as the information provided in the event is entirely related to the user’s profile or settings in a guild.

[khionu]

Attachments and Embeds shouldn’t be treated the same as Reactions, in that case. Attachments and Embeds are similar, but a Reaction is closer to an Edit than an Embed, imo, even though they are very much different. So, sure, but with some tweaking, to account for Reactions.