Max CPU usage after disconnecting from voice

It doesn’t happen all the time, but occasionally CPU usage will jump to max after calling <StreamDispatcher>.end() and <VoiceConnection>.disconnect(); it does not decline until the bot has been restarted. I experimented with having a delay between ending the dispatcher and disconnecting from the channel, but that didn’t seem to have much impact; while sometimes it would last longer before the CPU spike, the CPU would still eventually spike.

This issue is only in indev (I’ve reverted to master without a problem), and I’m unsure about where it could be since there hasn’t been a huge re-working of voice.

[appellation]

Terminating the FFMPEG process in https://github.com/hydrabolt/discord.js/blob/indev/src/client/voice/pcm/FfmpegConverterEngine.js#L35 with SIGKILL seems to resolve this problem (as well as a secondary problem with extra FFMPEG processes cluttering memory).

This raises the question of whether this solution is indicative of a problem somewhere else. Clearly, in some cases, FFMPEG is not correctly responding to the SIGTERM signal. I have not investigated into why this might be the case, nor what the proper solution to this might be. Obviously terminating the process with SIGKILL solves the problem, but it does seem to be a bit harsh.

[appellation]

I’ve also been seeing this on master again, but since I don’t have any idea of what’s causing it, I haven’t brought it up again.