`Customer.subscribe` method appears to use outdated request

I was writing tests for our app that uses dj-stripe. Thanks for writing and maintaining this complex package!!

We use stripe-mock for tests, which is pinned to the most recent API version. Using this version, a test was failing for an invalid request when attempting a Customer.subscribe(plan="<str>").

I checked the Stripe docs on creating a Subscription and it appears the items parameter is required, while plan is not supported.

Our app runs on an older version of the API so I haven’t seen this error in production. Hopefully I’m wrong?

[remi-stripe]

To provide a bit of context, passing plan as a parameter to the Subscription creation API has been deprecated for a few years. This happened when we introduced items to support multiple plans per subscription. While it still works in production, we undocumented it a few weeks ago to ensure new developers didn’t mistakenly integrate something actively deprecated. It will keep working though we do plan to release a new API version in the future blocking this, paired with the usage of Price instead of Plan overall in the API.

I would encourage you to move to using both items (which has existed for years now) and Price instead of Plan (though this is a newer introduction).

Hope it helps!

[therefromhere]

PS, this is one of the reasons dj-stripe doesn’t currently use stripe-mock for testing - as you say stripe-mock only supports the latest stripe API version, whereas dj-stripe pins to a known-good version.

See #567 for discussion of stripe-mock, and #892 for the current implementation of test fixtures - this is my slightly hare-brained scheme which uses a real (test-mode) stripe account to generate fixtures.

For my own applications that use dj-stripe I’ve had success using https://github.com/kevin1024/vcrpy to record fixtures of the stripe API calls (and other out-bound REST API calls).