Customer.valid_subscriptions should exclude SubscriptionStatus.incomplete

If people use Payment Elements to sell subscription by following this guide https://stripe.com/docs/billing/subscriptions/build-subscriptions?ui=elements#install-setup

People will create subscription using code below:

        subscription = stripe.Subscription.create(
            customer=customer_id,
            items=[{
                'price': price_id,
            }],
            payment_behavior='default_incomplete',
            expand=['latest_invoice.payment_intent'],
        )

This will create Subscription which has incomplete status (before we confirm the payment), and I do not think it is valid_subscriptions

    @property
    def valid_subscriptions(self):
        """
        Returns this customer's valid subscriptions
        (subscriptions that aren't canceled or incomplete_expired).
        """
        return self.subscriptions.exclude(
            status__in=[
                enums.SubscriptionStatus.canceled,
                enums.SubscriptionStatus.incomplete_expired,
            ]
        )

I think we should update Customer.valid_subscriptions to exclude enums.SubscriptionStatus.incomplete as well.

Thx.

[arnav13081994]

@kavdev Fair enough I will look at the Subscription Lifecycle and report back.

[jleclanche]

I’m a strong +1 on keeping these helper methods around.