Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Plugin modal window height

See original GitHub issue

The height of the plugins modal window is not calculated correctly into the cms.modal.js. I need to replace this line

var screenHeight = $(window).height();

with this

var screenHeight = window.innerHeight;

https://github.com/divio/django-cms/blob/develop/cms/static/cms/js/modules/cms.modal.js#L131

Issue Analytics

State:
Created 9 years ago
Comments:8 (4 by maintainers)

Top GitHub Comments

1reaction

steveneweycommented, Oct 15, 2014

I had this issue a few weeks ago and posted to the mailing list before discovering the solution. It’s an issue with jQuery and the document type…

Some investigation uncovered that $(window).height() was returning the document height instead of the window height. This happens when there’s no doctype declared on the page. A quick <!doctype html> and it was fixed!

1reaction

m05quit0commented, Oct 14, 2014

It depends of html layout markup. Setting css properties width and height to 100% for html element fix problem for me.