3.1.0 inline preview not working for some django-filer images
See original GitHub issueI have a page which has three instances of cmsplugin-filer image plugins on it. After upgrading to djangocms-text-ckeditor 3.1.0, only the first two can be double-clicked to edit (they both show the yellow border on hover and a blue border when single-clicked).
For the third image plugin instance, there is no border shown on hover or on single click. If I double-click the image, the editor becomes disabled, no clicks or scrolling possible within the editor (the minimize/maximize/‘x’ to close and the Cancel/Delete/Save buttons are the only things that still work):
The only difference between the plugins is that the third image plugin instance uses the ‘file link’ option to link the image to a cmsplugin-filer file.
If I click the ‘Source’ button in the editor, the rendered markup for the third plugin is broken:
<cms-plugin alt="Image - test.png " id="11854" render-plugin="true" title="Image - test.png"></cms-plugin>
<p> </p>
<figure id="image_plugin_700"><a href="/media/filer_public/81/fa/81fa62ff-51aa-4bf0-891c-223f6cc54768/test.pdf" target="_blank"><img alt="test.png" class="img-responsive" src="/media/filer_public_thumbnails/filer_public/24/fb/24fb47ed-203d-4402-8904-90825f4cb116/test.png__726x941_q85_crop_subsampling-2_upscale.png" /></a></figure>
Note that the <cms-plugin>
tag closed itself without wrapping the <figure>
tag and an empty <p>
was added.
Issue Analytics
- State:
- Created 7 years ago
- Comments:18 (18 by maintainers)
Top GitHub Comments
This appears to have fixed all the issues I reported. Thanks for your help and work on this!
https://github.com/divio/djangocms-text-ckeditor/pull/367 this one should fix the problem with the extra
<p>
tags