question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Hi @carltongibson @bittermandel

I’ve pushed an initial commit based upon the pull request to django-crispy-forms master from last week. It’s not much more than a POC at the moment, with the current tests passing.

Much work to be done; here are my current thoughts. This won’t be a complete list but is enough to be getting on with for now - and probably we can get an inital release out before completing all of them.

EDIT: I’ve updated the below to split into sections to give some sort of percieved importance. I’ll keep this list live for now.

Completed

  • Template imports - needs to be {% load tailwind_field %}
  • Setup GitHub actions for testing, isort, black, flake8
  • Include a default rendering option (something like {{ form|crispy }})
  • Setup development environment with crispy-test-project
  • Add oppinionated rendering to |crispy
  • Add an example image to README
  • code coverage + template coverage? (seems to be a bug with codecov, see PR)
  • GH Action - let’s try and cache the dependencies to stop pulling all the dependencies every time. e.g. Django get’s downloaded 14 times for every pull request that is merged = circa.105mb. Note: cache is 41mb per run (500mb for a merged PR?)
  • Docs why are images not showing (do we ‘just’ need to use RTD?). Note: Img files need to be lower case.
  • Should we publish something to PyPI now to get the name?
  • Custom objects - e.g. prepend/postpend
  • Find out why codecov went missing again. (It’s reporting https://codecov.io/gh/django-crispy-forms/crispy-tailwind, but it’s not commenting on PRs any more)
  • Non form errors (e.g. passwords do not match?)

Sooner ™️

  • Review project strucutre - can someone review how I’ve setup the licence, setup.py etc?
  • Add more tests for layout
  • Add test for Field layout object
  • Docs
  • Fix flake8 - we’re running well over on line length. Also why isn’t it failing!?

Later

  • What to do about radio / checkbox
  • Put tests into more logical structure.
  • Put note on django-crispy-forms that this template pack exists
  • Review to do list items I’ve left in the code
  • Tidy up code base
  • Review GH Actions - are they running as expected?
  • Refactor field / label class when using crispy filter. (don’t need to add classes to tailwind_filters - can we remove this file?!)

Issue Analytics

  • State:open
  • Created 3 years ago
  • Reactions:1
  • Comments:19 (18 by maintainers)

github_iconTop GitHub Comments

2reactions
smithdc1commented, Jun 16, 2020

Hi @marcorichetta 👋

Thank you for your interest in this package. To answer your questions:

What am I working on

Currently their are two main things. (We’ve moved on a bit since the image above, the standard widgets are now rendered nicely ‘out of the box’).

  1. Test coverage - it is very low at the moment. I’m hopeful most of it should just work at this point but…

  2. Docs - In particular the layout docs. Need to explain each layout item, where it is sourced from, what it looks like etc.

Grouped Checkboxes

Grouped checkboxes is a much wider issue for crispy-forms; they look like this on bootstrap as well. Not yet solved why crispy-forms outputs the groups instead of individual items.

Current PRs

The top three need a final review but should be good to go 🤞. Can’t quite remember about the status of the bottom one, I think most of it’s been merged from memory.

What Else

The to do list in the first post is up to date. Probably the next thing to think about is prepend/postpend layouts.

1reaction
justinmayercommented, Nov 22, 2020

@smithdc1: My pleasure. I hope that the flood of PRs wasn’t too annoying. I tried to break things up into discrete bits, since as a project maintainer myself I often find smaller, more-digestible submissions to be helpful.

Many thanks for having a look at Tailwind CSS v2. When time affords, I look forward to hearing more about what changes (if any) might be afoot. 👣

Read more comments on GitHub >

github_iconTop Results From Across the Web

Welcome to To Do
Microsoft To Do.
Read more >
To Do List and Task Management App | Microsoft To Do
The Microsoft To Do App sets you up for success by helping you manage, prioritize, and complete your goals and tasks.
Read more >
Microsoft To Do: Lists & Tasks - Apps on Google Play
Microsoft To Do is a task management app to help you stay organized and manage your day-to-day. You can use Microsoft To Do...
Read more >
Microsoft To Do on the App Store - Apple
Create to do lists, reminders, and notes for any purpose. Sync lists across devices and Microsoft 365 accounts to access daily planner and...
Read more >
Todoist | A To-Do List to Organize Your Work & Life
Trusted by 30 million people and teams. Todoist is the world's favorite task manager and to-do list app. Finally become focused, organized and...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found