Customize admin import forms problem

Following the docs (getting started) in the last section I got a problem. Everything works fine and the Author form shows normally but when I select the author and send an .xlsx file it doesn’t update the author field even after I confirm the import, it doesn’t update the author field. and this’s the code that I’m talking about from the docs :

from import_export.admin import ImportMixin
from import_export.forms import ImportForm
from import_export.forms import ConfirmImportForm
from django import forms

class CustomImportForm(ImportForm):
    author = forms.ModelChoiceField(
        queryset=Author.objects.all(),
        required=True)

class CustomConfirmImportForm(ConfirmImportForm):
    author = forms.ModelChoiceField(
        queryset=Author.objects.all(),
        required=True)

class BookResource(resources.ModelResource):

    class Meta:
        model = Book

class CustomBookAdmin(ImportMixin, admin.ModelAdmin):
    resource_class = BookResource

    def get_import_form(self):
        return CustomImportForm

    def get_confirm_import_form(self):
        return CustomConfirmImportForm

    def get_form_kwargs(self, form, *args, **kwargs):
        # pass on `author` to the kwargs for the custom confirm form
        if isinstance(form, CustomImportForm):
            if form.is_valid():
                author = form.cleaned_data['author']
                kwargs.update({'author': author.id})
        return kwargs


admin.site.register(Book, CustomBookAdmin)```

[andrewgy8]

Interesting. I was working on another lib a few weeks ago, and ran into an issue with isinstance usage. I had to also use issubclass. Could it be related?

[rymkapro]

Hi, I have similar issue. My problem that a get form class but not form class instance onto the form argument of get_form_kwargs method.