Remove django from install_requires in setup.py

Hi. I’d like to propose to remove django package from install_requires in setup.py, because it successfully breaks package updates with pip install -U django-import-export by installing the latest available django version, which is not really desirable in most cases.

Most of mature packages e.g. djangorestframework provide empty install_requires with install_requires=[] to avoid any conflicts.

In my opinion, most users will have django installed before installing django-import-export and I assume that nobody would expect that the django-import-export package would work without django.

References:

• https://github.com/django-nose/django-nose/issues/239
• https://github.com/django-guardian/django-guardian/issues/423

[pszpetkowski]

Actually, upgrade can be used without forced recursive upgrade. As http://pip-python3.readthedocs.io/en/latest/user_guide.html#only-if-needed-recursive-upgrade states one can provide --upgrade-strategy with only-if-needed value, which will effectively upgrade a dependency only if it does not satisfy the new parent requirements.

Issue resolved for me.

[jdufresne]

When I want to upgrade django-import-export, I want to do pip install -U django-import-export, but I don’t expect it to upgrade Django.

TBH, this feels like an issue with how pip works and not an error in the django-import-export list of requirements. I think it would be better to spend effort fixing the issue there instead of suggesting every Django package workaround the issue by not enumerating its requirements correctly. Here is at least one pip related issue, https://github.com/pypa/pip/pull/3194

Do you grab the newest version and pin on requirements manually? This works. But if want to do a pip install -U django-import-export and a pip freeze after, it will not work.

Take a look at pip-tools. It removes the manual pinning process as well as syncs a virtualenv to a strict list of packages.