Json-api renderer breaking when paired with JWT packages (simple-jwt & drf-jwt)

Ran into this issue today while setting up a backend -

line 479, in build_json_resource_obj ('id', encoding.force_text(resource_instance.pk) if resource_instance else None), AttributeError: 'dict' object has no attribute 'pk'

Found out that is occurring from this line of code located inside of renderers.py

('id', encoding.force_text(resource_instance.pk) if resource_instance else None),

link-to-code

in particular its the “resource_instance.pk” thats blowing up. This occurs whenever I’m using JWT packages simple-jwt or drf-jwt

If I change the line to

('id', encoding.force_text(resource_instance['user'].pk) if resource_instance else None),

Everything works. Ideally I’d like to avoid having to go down the route of forking, does anyone know how I could get past this? It seems the renderer is making an assumption about how the resource_instance should be returned from the JWT serializer.

[sliverc]

This serializer looks a bit odd because it returns user as data but doesn’t define field. If it wouldn’t need to be serialized it would need to be defined as RelatedField marked as read_only.

Also I just quickly tested it and cannot reproduce an error:

Test code:

    url = reverse('rest_login')

    data = {
        'data': {
            'attributes': {
                'password': 'password',
                'username': 'admin',
            },
            'type': 'loginViews'
        },
    }
    response = client.post(url, data=data)
    assert response.status_code == 200

This reproduces following output:

{'data': {'attributes': {'key': 'a1c94b5cfd5d503d95cafc5d08be8afa1c0dbbc7'},
          'id': 'a1c94b5cfd5d503d95cafc5d08be8afa1c0dbbc7',
          'type': 'loginViews'}}

Maybe overwriting serializer and marking user as related field might help you already.

Otherwise could you provide a PR potentially which reproduces this error within the json api example?

[sliverc]

@ewelinabuturla This issue is old and even though your issue might look similar it might not be. And when I read through it seems that I was actually never able to reproduce this issue.

I am locking this conversation. But if your issue still exists best open a pull request with a reproducing test for your issue (can also be an example application or similar if this is easier).