question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make Oscar agnostic of thumbnailing solution

See original GitHub issue

Oscar really shouldn’t care how thumbnails are generated. It leads to trouble when integrating e.g. django CMS as they use easy-thumbnails. There’s also solutions like thumbor and resrc.it better suited for handling thumbnails when using remote storages like S3.

I’m imagining a backend-agnostic oscar_thumb template tag that is easy to customise. As far as I’m aware, the only advanced usage of the thumbnail tag is crop=centre for the gallery thumbs, which surely could be made to work somehow.

Questions remaining:

  • Should we drop Sorl as a required dependency? That means PIL wouldn’t get installed by default, which makes the final environment lighter. But it probably doesn’t provide for a good out-of-the-box experience.

Issue Analytics

  • State:closed
  • Created 9 years ago
  • Reactions:2
  • Comments:16 (13 by maintainers)

github_iconTop GitHub Comments

5reactions
boghcommented, Aug 26, 2016

I’ve looked over @JostCrow implementation and I think it’s not a good idea to duplicate the templates. Give that there are quite a few. I was thinking a template tag that returns the thumbnail of the image and wraps both libraries and any future that wants to be used.

Allowing for a setting that will specify the THUMBNAIL_FUNCTION to be called and create and return the thumb of the image.

I will start working in this direction and I’m open to suggestions.

2reactions
sephiicommented, Apr 6, 2017
Read more comments on GitHub >

github_iconTop Results From Across the Web

Was Oscar Wilde an atheist? - Study.com
Answer and Explanation: Oscar Wilde was more of a deist than an atheist. Wilde was born and baptized into the Anglican Church, and...
Read more >
django-oscar Documentation
Oscar is an e-commerce framework for building domain-driven applications. It has flexibility baked into its core so.
Read more >
Evaluating Django-Oscar, a F/OSS Shopping Cart - Mike Slinn
In a previous blog post I discussed why I decided to check out the django-oscar e-commerce framework in depth.
Read more >
About - FRSecure
Providing Security Solutions that Make a Measurable Difference. Our team of experts is constantly developing solutions and training to assist clients in ...
Read more >
Freedom of Religion Means Freedom to Say No to Vaccines
When people say they are motivated by conscience, even implausibly, employers and government have no morally defensible choice but to take ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found