Make Oscar agnostic of thumbnailing solution
See original GitHub issueOscar really shouldn’t care how thumbnails are generated. It leads to trouble when integrating e.g. django CMS as they use easy-thumbnails
. There’s also solutions like thumbor and resrc.it better suited for handling thumbnails when using remote storages like S3.
I’m imagining a backend-agnostic oscar_thumb
template tag that is easy to customise.
As far as I’m aware, the only advanced usage of the thumbnail
tag is crop=centre
for the gallery thumbs, which surely could be made to work somehow.
Questions remaining:
- Should we drop Sorl as a required dependency? That means PIL wouldn’t get installed by default, which makes the final environment lighter. But it probably doesn’t provide for a good out-of-the-box experience.
Issue Analytics
- State:
- Created 9 years ago
- Reactions:2
- Comments:16 (13 by maintainers)
Top Results From Across the Web
Was Oscar Wilde an atheist? - Study.com
Answer and Explanation: Oscar Wilde was more of a deist than an atheist. Wilde was born and baptized into the Anglican Church, and...
Read more >django-oscar Documentation
Oscar is an e-commerce framework for building domain-driven applications. It has flexibility baked into its core so.
Read more >Evaluating Django-Oscar, a F/OSS Shopping Cart - Mike Slinn
In a previous blog post I discussed why I decided to check out the django-oscar e-commerce framework in depth.
Read more >About - FRSecure
Providing Security Solutions that Make a Measurable Difference. Our team of experts is constantly developing solutions and training to assist clients in ...
Read more >Freedom of Religion Means Freedom to Say No to Vaccines
When people say they are motivated by conscience, even implausibly, employers and government have no morally defensible choice but to take ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I’ve looked over @JostCrow implementation and I think it’s not a good idea to duplicate the templates. Give that there are quite a few. I was thinking a template tag that returns the thumbnail of the image and wraps both libraries and any future that wants to be used.
Allowing for a setting that will specify the THUMBNAIL_FUNCTION to be called and create and return the thumb of the image.
I will start working in this direction and I’m open to suggestions.
I started working on this here https://github.com/liip-forks/django-oscar/tree/agnostic-thumbnails