question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

StockRecord: rename price_excl_tax

See original GitHub issue

The docstring for price_excl_tax already explains what it truly is: the base price for tax calculations. I’ve had two projects where we knew the tax-inclusive price, and only calculated the price excl tax. I’d argue that a stock record is merely a record of a base price, and only the pricing policy gives it any meaning in regards to tax, so the field name should reflect that. I realize that the field is probably used directly more often than it should (instead of through pricing strategies), so we need a good idea about being friendly as far as backwards-compatibility is concerned.

Issue Analytics

  • State:closed
  • Created 8 years ago
  • Reactions:1
  • Comments:10 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
sasha0commented, Dec 15, 2017

After research and observation, I came to conclusion it does make sense to rename price_excl_tax into price but as @john-parton mentioned before, there’s no chance to make this change backwards compatible which drastically reduces motivation to apply this change.

I also totally agree with @maerteijn that we’d firstly deprecate this field and rename in the next major release (2.0).

0reactions
solarissmokecommented, Jul 17, 2020

We forgot about the renaming of price_excl_tax - will definitely do this before the next release.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Source code for oscar.apps.basket.abstract_models
Strategy hasn't " "found any stock record for product %s") % product) # Line ... This is used to compare offers before and...
Read more >
django-oscar Documentation - Read the Docs
How to change an existing URL pattern. Oscar has many views and associated URLs. Often you want to customised these URLs for your...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found