StockRecord: rename price_excl_tax
See original GitHub issueThe docstring for price_excl_tax
already explains what it truly is: the base price for tax calculations. I’ve had two projects where we knew the tax-inclusive price, and only calculated the price excl tax. I’d argue that a stock record is merely a record of a base price, and only the pricing policy gives it any meaning in regards to tax, so the field name should reflect that.
I realize that the field is probably used directly more often than it should (instead of through pricing strategies), so we need a good idea about being friendly as far as backwards-compatibility is concerned.
Issue Analytics
- State:
- Created 8 years ago
- Reactions:1
- Comments:10 (8 by maintainers)
Top Results From Across the Web
Source code for oscar.apps.basket.abstract_models
Strategy hasn't " "found any stock record for product %s") % product) # Line ... This is used to compare offers before and...
Read more >django-oscar Documentation - Read the Docs
How to change an existing URL pattern. Oscar has many views and associated URLs. Often you want to customised these URLs for your...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
After research and observation, I came to conclusion it does make sense to rename
price_excl_tax
intoprice
but as @john-parton mentioned before, there’s no chance to make this change backwards compatible which drastically reduces motivation to apply this change.I also totally agree with @maerteijn that we’d firstly deprecate this field and rename in the next major release (2.0).
We forgot about the renaming of
price_excl_tax
- will definitely do this before the next release.