Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Proposal: .gitignore dist/

See original GitHub issue

Having the dist/ directory in Git makes pull requests unnecessarily confusing and unwieldy.

I’m guessing that 98% of users are using WebMidi from the npm package. I propose:

Remove the dist/ directory from the Git repository - as the first commit
Then add dist/ to the .gitignore file - as the second commit

Then you’d have a workflow where the dist/ directory gets built locally before testing and/or publishing to npm. But there wouldn’t be a lot of diff craziness in pull requests or commits.

Issue Analytics

State:
Created a year ago
Comments:9 (9 by maintainers)

Top GitHub Comments

1reaction

Vexcitedcommented, Apr 2, 2022

Hello, I want to help for this issue !

I’ve already forked the project and made some modifications.

I added dist to .gitignore
I removed every commit lines in scripts and removed the “build and commit” scripts in package.json.

Now for the releases (to use manually with .zip), I think we could rewrite current script in scripts/release/release.js to, instead of commit the dist folder, release the dist folder to GitHub Releases.

0reactions

djipcocommented, Apr 3, 2022

Thanks to @Vexcited and his work on PR https://github.com/djipco/webmidi/pull/254, this has been implemented. I had to create a few releases to nail down all the details but it seems stable now.

P.S. Users who want to download the library manually can still go to the latest release page.