The v1.10.7 introduced a couple of breaking changes: Comparison vs v1.10.5
See original GitHub issueI’m checking the differences of the v1.10.5
and v1.10.7
due I had translations using multiple placeholders that they were getting translated correctly before, and after upgrading they fail.
The comparison link, between those two versions, is the following: https://github.com/dkfbasel/vuex-i18n/compare/v1.10.5...v1.10.7.
So, were before this was correctly working:
computedProp() {
const quantityClassName = this.$style[`${this.mainClassname}__quantity`];
const translationParameters = {
0: `<span id="${this.fromId}" class="${quantityClassName}">${from}</span>`,
1: `<span id="${this.toId}" class="${quantityClassName}">${to}</span>`,
2: `<span id="${this.totalId}" class="${quantityClassName}">${total}</span>`,
};
return this.$t(resultInfoKey, translationParameters);
}
With the version v1.10.7
returns the following
Not all placeholders found
.
And I’m starting to suspect the root cause of this issue is at this line of code. Which actually relates to #98 and #99.
Please, any feedback or fix, is welcome.
Issue Analytics
- State:
- Created 5 years ago
- Comments:5 (4 by maintainers)
Top Results From Across the Web
Changelog · Prodigy · An annotation tool for AI, Machine ...
This release includes a few breaking changes, mostly small improvements to inconsistent APIs, replacement of already deprecated behavior, or bug fixes that now ......
Read more >refs/tags/v1.10.8 - external/github.com/klauspost ... - Google Git
June 1, 2020 (v1.10.7): Added zstd decompression dictionary support. ... Breaking change, send nil for previous behaviour.
Read more >Changelog - Cypress Documentation
Read our Migration Guide which explains some breaking changes in more detail. We introduced several breaking changes to the Cypress configuration file detailed ......
Read more >Revision history - MakeMKV
Mac OS: Program produced random errors when running on OS X 10.11 El Captain or earlier versions; Linux: ccextractor is now part of...
Read more >runZero release notes
runZero users logging in via SSO are now presented with the terms and conditions ... The scan engine now supports full SNMP v1...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Hi @davidpelayo
Thank you for reporting this. Definitely not intended. I will look into this.
HI @davidpelayo,
This issue is quite likely due to the changed regular expression match that we use to identify placeholders in translation strings. With the new regex matcher, we require at least two characters, which breaks your code if the variable replacement results in a matcher with only one character (i.e. a number).
I will adapt the regex matcher to also include matches for single characters as long as they match [A-Za-z0-9_]. Stay tuned.