Consolidate FontAwesome dependencies

PreferencesFX uses both ControlsFX and FontAwesomeFX. ControlsFX provides a thin wrapper for the FontAwesome TrueType Font. As far as I can tell, PreferencesFX doesn’t use fonts specific to FontAwesomeFX.

As a consequence, projects that use PreferencesFX will get two copies of “fontawesome-webfont.ttf”:

165548 Sun Nov 01 13:43:28 PST 2020 org/controlsfx/glyphfont/fontawesome-webfont.ttf
 99468 Sat Jan 12 20:40:14 PST 2019 de/jensd/fx/glyphs/fontawesome/fa-brands-400.ttf
 30560 Sat Jan 12 20:40:14 PST 2019 de/jensd/fx/glyphs/fontawesome/fa-regular-400.ttf
114928 Sat Jan 12 20:40:14 PST 2019 de/jensd/fx/glyphs/fontawesome/fa-solid-900.ttf
165548 Sat Jan 12 20:40:14 PST 2019 de/jensd/fx/glyphs/fontawesome/fontawesome-webfont.ttf

After refactoring KeenWrite in an attempt to consolidate the TTF files (i.e., I removed all references to FontAwesomeFX in favour of using ControlsFX exclusively), I was surprised to see FontAwesomeFX still in use. Gradle’s dependency trace showed that PreferencesFX had the two references.

What do you think of revising PreferencesFX to use only the version of FontAwesome icons that is bundled with ControlsFX to avoid duplication?

[shoaniki]

Annnd it’s happened, just tried to add PreferencesFX to my project and I can’t because FontAwesomeFX was only on jcenter. Please consider making a release without that dependency.

(If this project really only requires two icons, might it be possible to mark the font dependency as optional and let applications provide their own icons if they want?)

[dlemmermann]

All of my projects use Ikonli and I do not care much about what ControlsFX uses. But we could make an exception in this case because there are only two icons used anyways: for the undo / redo buttons. If you want to you can submit a PR that changes that. Ideally very soon because on May 1st this project’s build pipeline breaks because of bintray stopping its services.