macOS compilation broken

🐛 Bug

With Xcode versions 13.1 and 13.4 and using clang following the installation instructions fails to build dgl.

To Reproduce

mkdir build
cd build
cmake -DUSE_OPENMP=off -DCMAKE_C_FLAGS='-DXBYAK_DONT_USE_MAP_JIT' -DCMAKE_CXX_FLAGS='-DXBYAK_DONT_USE_MAP_JIT' -DUSE_AVX=OFF -DUSE_LIBXSMM=OFF ..
make -j4

generates the following error:

Consolidate compiler generated dependencies of target dgl
[ 55%] Building CXX object CMakeFiles/dgl.dir/src/runtime/shared_mem.cc.o
[ 56%] Building CXX object CMakeFiles/dgl.dir/src/runtime/semaphore_wrapper.cc.o
[ 57%] Building CXX object CMakeFiles/dgl.dir/src/runtime/tensordispatch.cc.o
[ 57%] Building CXX object CMakeFiles/dgl.dir/src/runtime/system_lib_module.cc.o
/Users/apalha/work/libs/dgl/src/runtime/semaphore_wrapper.cc:45:3: warning: 'sem_init' is deprecated [-Wdeprecated-declarations]
  sem_init(&sem_, 0, 0);
  ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/usr/include/sys/semaphore.h:55:42: note: 'sem_init' has been explicitly marked deprecated here
int sem_init(sem_t *, int, unsigned int) __deprecated;
                                         ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/usr/include/sys/cdefs.h:204:40: note: expanded from macro '__deprecated'
#define __deprecated    __attribute__((__deprecated__))
                                       ^
/Users/apalha/work/libs/dgl/src/runtime/semaphore_wrapper.cc:73:17: error: use of undeclared identifier 'sem_timedwait'
  while ((ret = sem_timedwait(&sem_, &ts) != 0) && errno == EINTR) {
                ^
1 warning and 1 error generated.
make[2]: *** [CMakeFiles/dgl.dir/src/runtime/semaphore_wrapper.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/dgl.dir/all] Error 2
make: *** [all] Error 2

After inspection, commit cac3720b48dfe15fb3721d00624c2d18fec15680 introduced the changes that cause the compilation to fail. Tag 0.8.2 still works.

The reason for failing seems to be related to the use of sem_timedwait, which is no longer supported in macOS. See this thread for a discussion and possible solutions.

Expected behavior

Should build without errors.

Environment

• DGL Version (e.g., 1.0): latest commit, but any commit after cac3720b48dfe15fb3721d00624c2d18fec15680 should also fail
• Backend Library & Version (e.g., PyTorch 0.4.1, MXNet/Gluon 1.3): PyTorch
• OS (e.g., Linux): macOS 12.2.1
• How you installed DGL (conda, pip, source): source
• Build command you used (if compiling from source): followd installation instructions
• Python version: 3.8.13
• CUDA/cuDNN version (if applicable): not applicable
• GPU models and configuration (e.g. V100): not applicable
• Any other relevant information: as mentioned above, tried this with Xcode version 13.1 and 13.4 and both give the same error, reverting to commit tagged 0.8.2 solved the issue.

[RecLusIve-F]

@apalha @RecLusIve-F please have a try with latest mater branch…

There are no more errors now, thank you very much.

[Rhett-Ying]

thanks for reporting this. I will work on it.