question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

RGCN Example Link Prediction "--n-epochs" bug

See original GitHub issue

https://github.com/dmlc/dgl/blob/d3a058226cec48d48c556e4c4a19d619114bcc25/examples/pytorch/rgcn/link_predict.py#L194

To whom this may concern,

When running the link_predict.py with the --n-epochs flag, I encountered the algo exceeding my specified epochs. On closer inspection, I realized that the break statement to exit out of the while loop is nested within the step to save the best model.

I believe the proper fix should be:

if mrr< best_mrr:
    pass
else:
    best_mrr = mrr
    torch.save({...})
if epoch >= args.n_epochs:
   break

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
turogercommented, Mar 16, 2021

I’ll submit a pull request.

1reaction
classicsongcommented, Mar 16, 2021

Can you try to fix the bug?

Read more comments on GitHub >

github_iconTop Results From Across the Web

RGCN Exception on Link Prediction - Deep Graph Library
I was trying to use RGCN implementation for link prediction, however, it does not work. The problem arises when I try to evaluate...
Read more >
pytorch_geometric/rgcn_link_pred.py at master · pyg-team ...
Implements the link prediction task on the FB15k237 datasets according to the. `"Modeling Relational Data with Graph Convolutional Networks".
Read more >
Relational Graph Convolutional Networks: A Closer Look - arXiv
Abstract. In this paper, we describe a reproduction of the Relational Graph Convolutional Network (RGCN). Using our reproduction, we explain ...
Read more >
Graph Neural Networks: Link Prediction (Part II) - Dataiku blog
This article focuses on building GNN models for link prediction tasks ... Sample: Instead of using the entire neighborhood of a given node, ......
Read more >
Relational graph convolutional networks: a closer look - PeerJ
Commonly, KGE models are developed and tested using link prediction benchmark datasets. Two key examples of KGEs are TransE (Bordes et al., 2013) ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found