question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Client Dependency Framework (CDF) - Space in DesktopModule folder (module.css)

See original GitHub issue

Description of bug

When a desktop module has a space in the file path (ie. /DesktopModules/Test Module/), it appears that the Client Dependency Framework (CDF) is adding a “%20” to the module.css path causing the module.css not to be included int he composite CSS. This is only an issue when “Enable Composite Files” is enabled in Site Settings.

It appears to be treating the path as a URL rather than a directory. You can confirm this further by manually creating a folder with the “%20” included. For example, add a module.css to the following folder: “/DesktopModules/Test%20Module/” and it is included in the composite CSS.

Steps to reproduce

  1. Create a new desktop module with a space in the directory name
  2. Add a module.css file
  3. Enable “Enable Composite Files” in Servers > Server Settings > Performance
  4. The module.css file will not be included. Furthermore, you will see the following in the HTML comment in the header, confirming that a “%20” is added instead of a space: <!--CDF(Css|/DesktopModules/Test%20Module/module.css|DnnPageHeaderProvider|10)-->

Current behavior

If a desktop module has a space in its folder name, the module.css is not included in the composite CSS.

Expected behavior

The module.css should be included in the composite CSS. The included path should not have a “%20” but rather a space.

Screenshots

image

Affected version

  • 10.00.00 alpha build
  • 09.09.00 latest supported release

Affected browser

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer 11
  • Microsoft Edge (Classic)
  • Microsoft Edge Chromium

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
bdukescommented, Jun 23, 2021

My opinion is that it should work 😃

1reaction
mitchelsellerscommented, Jun 23, 2021

This is an interesting one and I’m curious to others’ opinions on this. Spaces in folder names are a REALLY bad idea for web applications.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Shazwazza/ClientDependency
CDF is a framework for managing CSS & JavaScript dependencies and optimizations for your web application. It allows for each individual component in...
Read more >
A deep dive into CSS Module
Dependencies are a huge cause of concern, and the ease of maintaining our CSS code depends greatly on how well our dependencies are...
Read more >
Can't import CSS/SCSS modules. TypeScript says "Cannot ...
TypeScript does not know that there are files other than .ts or .tsx so it will throw an error if an import has...
Read more >
What are CSS Modules and how to use it in React
CSS Modules are "CSS files in which all class names and animation names are scoped locally by default". Instead of having CSS files...
Read more >
CSS
CSS assets can contain dependencies referenced by @import syntax, as well as references to images, fonts, etc. via the url() function.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found