Client Dependency Framework (CDF) - Space in DesktopModule folder (module.css)
See original GitHub issueDescription of bug
When a desktop module has a space in the file path (ie. /DesktopModules/Test Module/), it appears that the Client Dependency Framework (CDF) is adding a “%20” to the module.css path causing the module.css not to be included int he composite CSS. This is only an issue when “Enable Composite Files” is enabled in Site Settings.
It appears to be treating the path as a URL rather than a directory. You can confirm this further by manually creating a folder with the “%20” included. For example, add a module.css to the following folder: “/DesktopModules/Test%20Module/” and it is included in the composite CSS.
Steps to reproduce
- Create a new desktop module with a space in the directory name
- Add a module.css file
- Enable “Enable Composite Files” in Servers > Server Settings > Performance
- The module.css file will not be included. Furthermore, you will see the following in the HTML comment in the header, confirming that a “%20” is added instead of a space:
<!--CDF(Css|/DesktopModules/Test%20Module/module.css|DnnPageHeaderProvider|10)-->
Current behavior
If a desktop module has a space in its folder name, the module.css is not included in the composite CSS.
Expected behavior
The module.css should be included in the composite CSS. The included path should not have a “%20” but rather a space.
Screenshots
Affected version
- 10.00.00 alpha build
- 09.09.00 latest supported release
Affected browser
- Chrome
- Firefox
- Safari
- Internet Explorer 11
- Microsoft Edge (Classic)
- Microsoft Edge Chromium
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (3 by maintainers)
My opinion is that it should work 😃
This is an interesting one and I’m curious to others’ opinions on this. Spaces in folder names are a REALLY bad idea for web applications.