question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

"Install New Theme" feature does not install specified files in correct folder

See original GitHub issue

Description of bug

DNN 9.2? - 9.8.1 When installing a theme via Manage > Themes > Install New Theme, files that are specified in the manifest file to be created in the base path of the theme folder are not actually created. However if you use Settings > Extensions > Install Extension to install the same theme, those files are indeed created. These two install methods appear to use different code to install themes in DNN and the Install New Theme option is not working correctly.

Steps to reproduce

  1. Download the TestTheme_1.0.0_install.zip created with nvQuickTheme TestTheme_1.0.0_install.zip

  2. Open the zip file and you will see that the zip file contains the following files “default.png”, thumbnail_default.png", and “LICENSE”, among other files.

ThemeInstallZip

  1. Open and view the manifest file and you will see that the manifest file specifically creates those files at the root of the theme folder.

ManifestFile

  1. In a clean new install of DNN that has the Install New Theme feature (9.2? - 9.8.1) use this feature to install the TestTheme theme, and view the Package Installation Report before clicking on “Done” and closing the install theme window. You should see that DNN thinks that the files were created successfully.

InstallConfirmationMessage

  1. Navigate to the new TestTheme folder in the DNN instances Skin folder. You can see that the files were not actually created.

ThemeFolder

  1. To prove that this is most likely a bug in DNN, and not the attached theme, use Settings > Extensions and uninstall the theme and be sure to tick off the “Delete Files?” checkbox.

  2. Use Settings > Extensions > Install Extension to install the same TestTheme theme.

  3. Navigate to the new TestTheme folder in the DNN instances Skin folder. You can see that this time the files were created as expected.

Affected version

  • 10.00.00 alpha build
  • 09.08.01 latest supported release and all previous versions that have the Manage > Themes > Install New Theme feature
  • 09.01.01

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
Timo-Breumelhofcommented, Feb 12, 2021

Can it be that “Manage > Themes > Install New Theme” was intended to replace the previous “Installing a theme for one specific Portal”, but is not implemented correclty? Like installing a Theme from Admin > Extension in DNN 7? FYI, a Portal Specific Theme is still very useful IMO, although I would prefer the option to assign a Theme to a portal as we do with modules.

1reaction
skrantzmancommented, Feb 4, 2021

bdukes,

Good catch. I was so focused at looking to see if the files were created, I did not look carefully enough at the path. So it appears that if you use Settings > Extensions > Install Extension to install the theme, the files are created in the correct location, Portals\_default....

PIR_InstallExtension

Yet if you use Manage > Themes > Install New Theme to install the theme, the files are created in the wrong location of Portals\0-System....

PIR_InstallNewTheme

If I navigate to that path on the website, those files were indeed created in the 0-System portal folder. Mostly likely a an incorrect path reference for the install script in the code for that method.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Fix the Error: "The package could not be installed. ...
Learn how to fix the following error in WordPress: "The package could not be installed. the theme is missing the style.css stylesheet."
Read more >
How To Fix the “Installation Failed: Destination Folder ...
Are you running into the “Installation Failed: Destination Folder Already Exists” Error? Here is how to fix the duplicate folder error.
Read more >
How to Fix Destination Folder Already Exists Error in ...
Simply go to the Plugins or Appearance » Themes page and manually upload the zip folder from your computer. WordPress will then tell...
Read more >
How to install a new theme for WordPress - Hosting
Navigate to the Files section >> the File Manager menu: 3. Move to the website directory root and locate /wp-content/themes/ folder. Click the...
Read more >
Installing Themes
Go to "Appearance" (/admin/appearance) on the main Administration menu of your site. Click 'Install' to install the theme and click "set as default'...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found