TabInfo HasChildren falsely reports True with former child page(s) in the Recycle Bin

Description of bug

When using the property TabInfo .HasChildren from code, if the page has a page or pages in the recycle bin that were previously children of that page, the HasChildren property will still be true.

Steps to reproduce

List the steps to reproduce the behavior

1. Go to Content / Pages
2. Add a page or two to an existing page
3. Delete the new pages so they are in the recycle bin
4. Add a quick RazorHost module to the page, run this script:

<p>Dnn.Tab.HasChildren = @Dnn.Tab.HasChildren</p>

Current result

HasChildren = True

Expected result

HasChildren = False

DNN Version [x] 9.3.2

Affected browser

All

[mitchelsellers]

Sadly, I believe the current behavior is in fact correct. There are children tabs under the parent, it just so happens that the tab is deleted, however, it is a soft delete.

There are other situations in menu templates for example where the “HasChildren” property isn’t exactly proper either. For example, if all children have been hidden from the menu HasChildren would also be true, however, it would not have any items to include in a menu, etc.

Looking at your desired behavior, there is a real thought of a “HasVisibleChildren” property that would be helpful for menu construction.

[sleupold]

I agree with @mitchelsellers, the best option would be a “hasActiveChildren”, which checks isdeleted, display dates and workflow states as well.