Allow to assign more than one role in a project.

When I given a user two role(project_admin and annotator), I got a error with:

backend_1   |   File "/app/api/serializers.py", line 98, in get_current_users_role
backend_1   |     queryset, project=instance.id, user=self.context.get("request").user.id
backend_1   |   File "/usr/local/lib/python3.6/site-packages/django/shortcuts.py", line 93, in get_object_or_404
backend_1   |     return queryset.get(*args, **kwargs)
backend_1   |   File "/usr/local/lib/python3.6/site-packages/django/db/models/query.py", line 403, in get
backend_1   |     (self.model._meta.object_name, num)
backend_1   | api.models.RoleMapping.MultipleObjectsReturned: get() returned more than one RoleMapping -- it returned 2!

There may more than one role of users_role, so it should replace get_object_or_404 with filter :

https://github.com/doccano/doccano/blob/v1.0.2/app/api/serializers.py#L98

        queryset = RoleMapping.objects.values("role_id__name")
        if queryset:
            users_role = get_object_or_404(
                queryset, project=instance.id, user=self.context.get("request").user.id
            )
            for key, val in role_abstractor.items():
                role_abstractor[key] = users_role["role_id__name"] == val
        return role_abstractor

[ljades]

Is there an update on this? It seemed like consensus was reached to mark this as a bug instead of a feature, correct? It should not be allowed to add a user to more than one role.

It seems like any user who is currently assigned to a role for a given project already should not show up in the dropdown (or be validated against if selected) for new project member roles.

[c-w]

@mymusise Yes, that’s correct. Each user/project/role pair should be unique. If this is not currently being enforced, I suspect it’s a bug with the v1 UI.

@kuraga That sounds like a bug in the validation logic in RoleMapping. The error for that situation should be a 400.