question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

feature request: ability to configure the github domain of the default git context (for Github Enterprise users)

See original GitHub issue

The domain of the default context is hard-coded to github.com: https://github.com/docker/build-push-action/blob/6a12baa86738bf273e82a4554bff19fd63295b85/src/context.ts#L40

For users of Github Enterprise running on a custom domain like git.mycompany.com it would be great if this would be configurable like:

[...]
      -
        name: Build and push
        id: docker_build
        uses: docker/build-push-action@v2
        with:
          push: false
          tags: user/app:latest
          ghdomain: git.mycompany.com
[...]

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
crazy-maxcommented, Mar 31, 2021

@digitalkram

Yes just wanted to be sure github.server_url is populated with the right value in the context, which is the case so I’ll be able to improve the default Git context for this action. This will give us:

_defaultContext = `${github.server_url}/${github.context.repo.owner}/${
  github.context.repo.repo
}.git#${github.context?.ref?.replace(/^refs\//, '')}`;
0reactions
codezninjacommented, Apr 5, 2021

sigh I need my coffee already 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

Enterprise Server 3.5 release notes - GitHub Docs
Get started, troubleshoot, and make the most of GitHub. Documentation for new users, developers, administrators, and all of GitHub's products.
Read more >
Configuring a custom domain for your GitHub Pages site
Configuring a custom domain for your GitHub Pages site. You can customize the domain name of your GitHub Pages site. GitHub Pages is...
Read more >
Enterprise Server 3.6 release notes - GitHub Docs
In a repository's settings, enabling the option to allow users with read access to create discussions does not enable this functionality.
Read more >
Enterprise Server 3.7 release notes - GitHub Docs
Get started, troubleshoot, and make the most of GitHub. Documentation for new users, developers, administrators, and all of GitHub's products.
Read more >
Enterprise Server 3.3 release notes - GitHub Docs
On a freshly set up GitHub Enterprise Server instance without any users, an attacker could create the first admin user. Custom firewall rules...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found