question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

split models and commands APIs

See original GitHub issue

Didn’t found this as issue. Something that i suggested in comments. For discussion.

When this library initially existed it had request models separated from CMDs. That allowed to have CMD creation logic separately from models. It should also allow do serder on request models. Example could be http://download.eclipse.org/jgit/site/4.4.0.201606070830-r/apidocs/index.html with org.eclipse.jgit.api High-level API commands (the porcelain of JGit). and other low level APIs. If somebody wants java docker client analog API, then ITs CMD, if somebody wants fill request object manually and send - “then low level”.

Starting from 1.12 docker changes POST /containers/(id or name)/start no longer accepts a HostConfig. that mean that - either we should stop supporting <1.10 ("starting container with HostConfig was deprecated since v1.10 and removed in v1.12"}).

  • Either we should bundle more conditional logic. Keeping this logic in separate CMD without model imho sounds better.

PS. if API the same for 1.10-1.12 then i think we can ignore 1.9 version.

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:7 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
marcuslinkecommented, Jul 1, 2016

As I stated before docker-java is low-level only. The fact we have introduced some high-level logic to commands is a workaround for a bad remote API design. We could implement high level API/commands on top of the existing low-level commands but this has nothing to do with this discussion here in my oppinion.

@KostyaSha So as I understand you want address different remote API versions with different request models? But what is with differences/changes in (http) parameters then? Letting the user choose which request model to use? This sounds like a bad idea. Supporting of multiple remote API versions is completely offtopic here is guess.

0reactions
stale[bot]commented, Jun 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to split a large OpenAPI document into multiple files
1. Open a new terminal. Then, install the package swagger-cli globally: · 2. Run the command to merge all the files into one:...
Read more >
CQRS - Martin Fowler
The change that CQRS introduces is to split that conceptual model into separate models for update and display, which it refers to as...
Read more >
Modelling commands in REST api - Stack Overflow
I am looking for a good way to model commands that change the status of a resource in a REST api. I have...
Read more >
Working with models and mapping templates - Amazon API ...
A mapping template is a script expressed in Velocity Template Language (VTL) and applied to the payload using JSONPath expressions . The payload...
Read more >
Split index API | Elasticsearch Guide [master] | Elastic
The split index API allows you to split an existing index into a new index, where each original primary shard is split into...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found