Docker Hub images are outdated, undocumented, duplicated, or don't exist.
See original GitHub issueImage Problems
-
Old Images: Code has changed in this repo and images are older than the code, causing old PR fixes to have no effect if you’re using the official images. One example:
dockersamples/examplevotingapp_worker:latest
is two years old but I fixed a 100% CPU issue nearly two years ago. Running current image will still spike CPU. -
Missing Images: Images for alternate builds don’t always exist. One example:
This repo has a java
worker
as an alternative to the default dotnetworker
, but Hub has no image for that. I recommend building it as tagjava
. -
Duplicate Image Repos: Images are duplicated in different Hub repos. One example:
dockersamples/examplevotingapp_worker
anddockersamples/worker
are the same app but different build dates. The former is what’s used in all yaml and in README and what we’ve used for many years. The latter has a new build, and I’m guessing was created by the new Jenkinsfile added a year ago to help automate image builds, which is great, but that file is pushing to the wrong Hub repos and is not complete with the various tags and alt builds. Doing some quick searching it looks like no one is using the new image repos, so it would be OK to remove them and stick with the origionals. -
No Image Tag Docs: To help people get the most out of these images and demo, it would be quite helpful to have a table in the README.md listing all the images, their tags, and the reason for those tags. One example:
What is the difference between
:latest
,:before
, and:after
? What tags are for what OS/arch?
Suggested Solutions
If the Jenkinsfile is indeed the future, I think a single PR could fix all these issues by fixing the current image repo/tags and adding all the alt builds to it, along with a README update on tag options for demos.
- Fix current repo names for the 3 demo apps in Jenkinsfile
- Add alt builds of the 3 demo apps to Jenkinsfile
- Ensure all tags are covered by the pushes in Jenkinsfile
- Delete misnamed Hub repos
- Update README.md with a table of tags and uses
I’m looking for a thumbs up from maintainers that this would be the prefered resolution, and I’ll get started on a PR. It looks like the Jenkinsfile will test the new builds in the PR but won’t test the push commands until it’s merged to master 😬
Issue Analytics
- State:
- Created 4 years ago
- Reactions:4
- Comments:6 (5 by maintainers)
Top GitHub Comments
I’m all about that. How can we help? PR a GA using the Docker Hub Action?
I’m thinking this can be closed now that #263 and #271 have been merged. Thoughts @BretFisher?