Add option to disable double-click creating a floating window.

A computer-challenged customer is having difficulties accidentally double-clicking the dockpanel tabs which causes them to undock and turn into a floating window. This can be a problem when not expecting it. Setting the DockAreas property is not sufficient as the ability to undock is still desired - just not when double-clicked.

Option added in DockPanel.cs:

        private bool m_floatOnDoubleClick;
        [LocalizedCategory("Category_Docking")]
        [LocalizedDescription("DockPanel_FloatOnDoubleClick_Description")]
        [DefaultValue(true)]
        public bool AllowFloatOnDoubleClick
        {
            get
            {
                return m_floatOnDoubleClick;
            }
            set
            {
                m_floatOnDoubleClick = value;
            }
        }

Option checked in DockPaneStripBase.cs:

        [SecurityPermission(SecurityAction.LinkDemand, Flags = SecurityPermissionFlag.UnmanagedCode)]
        protected override void WndProc(ref Message m)
        {
            if (m.Msg == (int)Win32.Msgs.WM_LBUTTONDBLCLK)
            {
                base.WndProc(ref m);

                int index = HitTest();
                if (DockPane.DockPanel.AllowEndUserDocking && DockPane.DockPanel.AllowFloatOnDoubleClick && index != -1)
                {
                    IDockContent content = Tabs[index].Content;
                    if (content.DockHandler.CheckDockState(!content.DockHandler.IsFloat) != DockState.Unknown)
                        content.DockHandler.IsFloat = !content.DockHandler.IsFloat;	
                }

                return;
            }

            base.WndProc(ref m);
            return;
        }

Help text added in Strings.resx: DockPanel_FloatOnDoubleClick_Description Allow document to float (undock) when tab is double-clicked.

[jakehedlund]

Totally understand, that’s why I made the three-line addition and submitted it instead of just suggesting the feature.

This option would also provide the inverse option that the FloatWindow class already has:

private bool m_doubleClickTitleBarToDock = true; public bool DoubleClickTitleBarToDock { get { return m_doubleClickTitleBarToDock; } set { m_doubleClickTitleBarToDock = value; } }

Anyway, I do like DockPanelSuite and how feature-rich it is. Keep up the good work.

On Tue, Mar 20, 2018 at 8:09 PM, Lex Li [e-mail] wrote:

The current bar to include some feature in DockPanel Suite is higher than ever, as maintainers do have quite limited time to review the changes. Many pull requests are pending due to the same reason.

If something can be easily implemented in a custom theme, then you are not bind to DPS itself and can do whatever changes you like.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dockpanelsuite/dockpanelsuite/issues/546#issuecomment-374822767, or mute the thread https://github.com/notifications/unsubscribe-auth/AJIeYQS5-qEo8dBjWVwjI7OhaJ2GnDowks5tgcROgaJpZM4Sw55E .

[DanCarterGMSL]

I’ve just tried the double-clicking behaviour in VS 2015, and it doesn’t undock a document. Perhaps this suggests that the VS2015 themes should be changed, so that double-clicking a tab does not undock the document?