Consecutive releases on GitHub not always making it to Dockstore

Describe the bug A user had our GitHub app installed on a repository on 2020-07-23. They made 2 consecutive releases within about 30 seconds of each other (11:17:27am and 11:17:59am), and only the first release made it in. After waiting for a period of time and then trying again, they were able to get the second release in (11:22:08).

Looking at the code, seems like the second release failed with the following

! at io.dockstore.webservice.helpers.GitHubSourceCodeRepo.getDockstoreYml(GitHubSourceCodeRepo.java:769)

To Reproduce Steps to reproduce the behavior:

1. Install our github app
2. Add a .dockstore.yml to a repository
3. Make two successive releases
4. Second release may not be recorded on Dockstore.

Expected behavior Both releases should have made it in (assuming they both had valid dockstore.yml files)

┆Issue is synchronized with this Jira Bug ┆Epic: Automated sync of Dockstore and GitHub apps
 ┆Fix Versions: Dockstore 1.9.X ┆Issue Number: DOCK-1511 ┆Sprint: Sprint 44- Sea Horse ┆Issue Type: Bug

[coverbeck]

Discussed with Greg and turns out it was deployed on staging – I was looking in the wrong place. Closing; sorry for the confusion.

[coverbeck]

Cool findings.

1. Suggest we target this for a hotfix.
2. Did not realize that we couldn’t distinguish this failure from a legit failure, so yes you’re right. But I went ahead and created a ticket, the one I should have already created, for other cases where we could signal to retry, #3830