"Launch with" snippet does not work for Workflows

Bug Report

The main page for a workflow contains as snippet of “Launch with” code that looks like this:

# alternatively, cwltool can run a workflow directly when all inputs and outputs are available on the local filesystem
$ cwltool --non-strict https://dockstore.org:8443/api/ga4gh/v1/tools/%23workflow%2FICGC-TCGA-PanCancer%2FOxoG-Dockstore-Tools%2Fpcawg-oxog-full-workflow/versions/develop/plain-CWL/descriptor Dockstore.json

The URL generated for this snippet (or maybe the API behind it?) does not work.

Expected behaviour

Users expect to be able to execute that code and have the workflow run.

Actual behaviour

Error 500.

Navigate to “https://dockstore.org:8443/api/ga4gh/v1/tools/%23workflow%2FICGC-TCGA-PanCancer%2FOxoG-Dockstore-Tools%2Fpcawg-oxog-full-workflow/versions/develop/plain-CWL/descriptor” in your browser and you will see:

{
"code": 500,
"message": "There was an error processing your request. It has been logged (ID 7099a2c2b9db6b63)."
}

Steps to reproduce the behaviour

Copy and paste the second “Launch with…” snippet of code for a workflow, and try running it.

This was originally reported by Chen, on Junjun’s team.

@garyluu also did a quick test and seems to think that this feature works for fine tools, but not for workflows.

[garyluu]

This appears to be fixed in my Aug 1 pull request. Tested with:

• http://<ip>:8080/api/ga4gh/v1/tools/quay.io%2Fwtsicgp%2Fdockstore-biobambam2%2Fbamtofastq/versions/1.0.0/plain-CWL/descriptor
• http://<ip>:8080/api/ga4gh/v1/tools/%23workflow%2Fdenis-yuen%2Fhello-dockstore-workflow%2Fhello-world/versions/testCWL/plain-CWL/descriptor

These are shown by the launch cwltool command with tools from the backup_db.sql. Both entries have an entry name without a corresponding entry that doesn’t have an entry name (quay.io/wtsicgp/dockstore-biobam2 and denis-yuen/hello-dockstore-workflow does not exist).

[garyluu]

Update: This seems to affect…

• Tools with a tool path on both production and with UI2 because the UIs are giving the wrong URL
• Workflows with a workflow path on both production and with UI2 because of the webservice discarding the workflow name